[pve-devel] applied: [PATCH qemu-server v2 1/1] fix 1734: clone VM: if deactivation fails demote error to warning

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Mar 8 13:56:15 CET 2024


Am 06/03/2024 um 15:08 schrieb Hannes Duerr:
> When a template with disks on LVM is cloned to another node, the volumes
> are first activated, then cloned and deactivated again after cloning.
> 
> However, if clones of this template are now created in parallel to other
> nodes, it can happen that one of the tasks can no longer deactivate the
> logical volume because it is still in use.  The reason for this is that
> we use a shared lock.
> Since the failed deactivation does not necessarily have consequences, we
> downgrade the error to a warning, which means that the clone tasks will
> continue to be completed successfully.
> 
> Signed-off-by: Hannes Duerr <h.duerr at proxmox.com>
> ---
> changes since v1:
> - fix nits and spelling
> 
>  PVE/API2/Qemu.pm | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
>

applied with Friedrich's T-b, thanks!

I also made a small follow-up commit trying to address some smaller
code-style nits.




More information about the pve-devel mailing list