[pve-devel] [PATCH manager] ceph: pool edit: set target ratio to 0 when the value is unset

Fiona Ebner f.ebner at proxmox.com
Wed Mar 6 16:38:33 CET 2024


Am 06.03.24 um 16:17 schrieb Maximiliano Sandoval:
> Fiona Ebner <f.ebner at proxmox.com> writes:
> 
>> It might be cleaner to just use
>> emptyValue: 0,
>> in the field declaration like is already done for the "Target Size"
>> field. And the same issue is also present for the "Min. # of PGs" field,
>> right?
> 
> Thanks for the emptyValue tip, I didn't know about it. Unfortunately, I
> tested this and it didn't work.
> 

Yes, sorry. Unfortunately, that is a feature specific to
PVE.form.SizeField, respectively Proxmox.form.SizeField.

For the "Min. # of PGs" field, we could add a similar feature to
proxmoxintegerfield. And the "Target Ratio" field is just a numberfield,
so would need yet another instance of the feature. So maybe not worth it.




More information about the pve-devel mailing list