[pve-devel] [PATCH docs 6/9] installation: iso: improve & align wording with pmg-docs

Christoph Heiss c.heiss at proxmox.com
Tue Mar 5 13:05:45 CET 2024


Thanks for the review!

On Tue, Mar 05, 2024 at 09:38:02AM +0100, Gabriel Goller wrote:
> On Mon Mar 4, 2024 at 2:22 PM CET, Christoph Heiss wrote:
> > +When copying and setting up the packages has finished, you can reboot the
> > +server. This will be done automatically after a few seconds by default.
>
> I would remove the `by default` so that the sentence becomes:
>
>     This will be done automatically after a few seconds.

Well, the option to automatically reboot can be changed and is on by
default, so it makes sense IMO to have that bit in there. Although the
sentence can probably be rephrased a bit to make it read easier - I'll
see what I can come up with for v2.

>
> > +. Log in using the `root` (realm 'PAM') username and the password chosen during
> > +installation.
>
> I think you need to fix the indentation here...
>

Will do, although we have (esp. in pmg-docs) a mix-match of both styles,
since it seems not not matter to asciidoc.
I will then probably go about and fix all the other instances too, if
I'm already it at ..

>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>




More information about the pve-devel mailing list