[pve-devel] [PATCH manager] ui: display edit: add warning when SPICE memory configuration can lead to failing display initialization

[Fiona Ebner]

which happens with either SeaBIOS+q35 or OVMF+efitype=2m as reported
in https://bugzilla.proxmox.com/show_bug.cgi?id=3726

Suggested-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
---
 www/manager6/qemu/DisplayEdit.js | 40 ++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/www/manager6/qemu/DisplayEdit.js b/www/manager6/qemu/DisplayEdit.js
index 9bb1763e..10ef3242 100644
--- a/www/manager6/qemu/DisplayEdit.js
+++ b/www/manager6/qemu/DisplayEdit.js
@@ -3,6 +3,8 @@ Ext.define('PVE.qemu.DisplayInputPanel', {
     xtype: 'pveDisplayInputPanel',
     onlineHelp: 'qm_display',
 
+    spiceMemoryHintRelevant: false,
+
     onGetValues: function(values) {
 	let ret = PVE.Parser.printPropertyString(values, 'type');
 	if (ret === '') {
@@ -11,6 +13,16 @@ Ext.define('PVE.qemu.DisplayInputPanel', {
 	return { vga: ret };
     },
 
+    updateSpiceMemoryHint: function() {
+	if (this.spiceMemoryHintRelevant) {
+	    let type = this.down('field[name=type]').getValue();
+	    let memory = this.down('field[name=memory]').getValue();
+	    this.down('label[name=spice-memory-hint]').setHidden(
+		!type?.match(/^qxl\d?$/) || memory <= 128
+	    );
+	}
+    },
+
     items: [{
 	name: 'type',
 	xtype: 'proxmoxKVComboBox',
@@ -49,6 +61,8 @@ Ext.define('PVE.qemu.DisplayInputPanel', {
 		    memoryfield.setEmptyText(Proxmox.Utils.defaultText);
 		}
 		memoryfield.setDisabled(disableMemoryField);
+
+		this.up('panel').updateSpiceMemoryHint();
 	    },
 	},
     },
@@ -60,6 +74,18 @@ Ext.define('PVE.qemu.DisplayInputPanel', {
 	maxValue: 512,
 	step: 4,
 	name: 'memory',
+	listeners: {
+	    change: function(cb, val) {
+		this.up('panel').updateSpiceMemoryHint();
+	    },
+	},
+    },
+    {
+	xtype: 'label',
+	text: gettext("SPICE memory > 128 MiB may not work with current EFI type or machine type"),
+	userCls: 'pmx-hint',
+	name: 'spice-memory-hint',
+	hidden: true,
     }],
 });
 
@@ -83,6 +109,20 @@ Ext.define('PVE.qemu.DisplayEdit', {
 	me.load({
 	    success: function(response) {
 		me.vmconfig = response.result.data;
+
+		// see bug #3726
+		if (me.vmconfig.bios === 'ovmf') {
+		    let efitype = '2m';
+		    if (me.vmconfig.efidisk0) {
+			let drive = PVE.Parser.parsePropertyString(me.vmconfig.efidisk0, 'file');
+			efitype = drive.efitype ? drive.efitype : efitype;
+		    }
+		    me.down('pveDisplayInputPanel').spiceMemoryHintRelevant = efitype === '2m';
+		} else {
+		    me.down('pveDisplayInputPanel').spiceMemoryHintRelevant =
+			me.vmconfig.machine?.match(/q35/);
+		}
+
 		let vga = me.vmconfig.vga || '__default__';
 		me.setValues(PVE.Parser.parsePropertyString(vga, 'type'));
 	    },
-- 
2.39.2