[pve-devel] [PATCH pve-network 0/7] add dhcp support for all zones

[DERUMIER, Alexandre]

Hi Stefan !  

I don't known the roadmap for dhcp, but I'll have time to help  in
March. I don't have looked at qinq yet.




>>I've had another look at this patch series and I think I found the
>>reason for the issue(s) I encountered during my testing.
>>
>>One issue is related to the new IP forwarding settings. It seems like
>>they are not applying. I've looked at the ifquery output after
>>creating
>>a QinQ / VLAN zone with DHCP enabled:

>>It seems like the ip-forward settings do not get applied and
>>therefore
>>the command 'fails'. The bridges are up and working but IP forwarding
>>is
>>enabled:
>>
>>root at hoan-02:~# cat /proc/sys/net/ipv4/conf/vlan4/forwarding
>>1
>>
>>root at hoan-02:~# cat /proc/sys/net/ipv4/conf/qinq5/forwarding
>>1

what is the output of "ifreload -a -d"  ?



>>The other issue was using QinQ zone with a bridge that has no bridge
>>port configured and is not vlan-aware. In that case status is
>>checking
>>for the existence of the sv_<id> interface but it doesn't exist since
>>there isn't a bridge port.
>>This is also occuring without this patch, so no show stopper here
imo.

mmm, good catch, I'll look to add a check for this.
I'll check too for vlan zone, with non vlan-aware bridge without
interface.



BTW, for dnsmasq + ipv6 with evpn/vrf, we need to add a patch.

What do you think about providing a proxmox package for dnsmasq with
this patch,  + remove the default dnsmasq service.  (as currently it's
a little bit hacky, with manually disabling the main service)



> It just miss the ip for dhcpserver different than gateway for ipv6
> handling for vlan/qinq/vxlan, but it should be easy to implement.
> 
> Also, for ipv6 in vrf, it need a patch for dnsmasq, so I think this
> will need to proxmox dnsmasq package version.