[pve-devel] [PATCH manager v3 04/19] ui: dc: backup: show 'Job ID' column

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Feb 20 16:23:35 CET 2024


Am 16/02/2024 um 10:15 schrieb Lukas Wagner:
> This is useful for creating matchers based on the 'backup-job'
> metadata field.
> 
> Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
> ---
>  www/manager6/dc/Backup.js | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
> index 4beb84c0..fb4df0a7 100644
> --- a/www/manager6/dc/Backup.js
> +++ b/www/manager6/dc/Backup.js
> @@ -774,9 +774,8 @@ Ext.define('PVE.dc.BackupView', {
>  		    sortable: true,
>  		},
>  		{
> -		    header: gettext('ID'),
> +		    header: gettext('Job ID'),
>  		    dataIndex: 'id',
> -		    hidden: true,
>  		},
>  		{
>  		    header: gettext('Node'),

I prefer just showing the ID in the advanced section of the General tab
inside the edit window instead, like your next patch does.

As I'd slightly prefer to avoid showing those rather unwieldy IDs for a
feature that's often setup only once, especially as a user cannot even
copy+paste easily from the grid.
User can still enable this column themselves, if more often used (albeit
yes, the header options are currently not as easily discoverable as they
could be)




More information about the pve-devel mailing list