[pve-devel] applied: [PATCH v2 acme] Fix EBA MAC key decoding

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Feb 12 09:54:43 CET 2024


Am 25/01/2024 um 09:28 schrieb YU Jincheng:
> Accroding to RFC 8555:
> 
>> The MAC key SHOULD be provided in base64url-encoded form...
> 
> However, currently we are only decoding the MAC key as base64.
> This patch chooses the correct function to decode the user provided
> MAC key. This can fix authentication error when a user uses command
> `pvenode acme account register` and paste the EBA MAC key as prompted.
> 
> Signed-off-by: YU Jincheng <shana at zju.edu.cn>
> ---
>  src/PVE/ACME.pm | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
>

applied, with Folke's T-b, thanks!

I fixed a small typo in the commit message and while at it I
reworded the commit subject to better fit our style (and to make
it easier to write a debian/changelog entry from this).




More information about the pve-devel mailing list