[pve-devel] [PATCH common 1/2] REST environment: warn helpers: use warn instead of printing to stderr

[Fiona Ebner]

Like this, __WARN__ handlers will still be called. In particular,
daemons like pvestatd will set a __WARN__ handler and also log
warnings to syslog. The intention behind introducing log_warn() was to
make warnings more visible, not less, so fix the semantics to make
sure switching from warn to log_warn() does not have this unintended
side-effect.

Reported-by: Friedrich Weber <f.weber at proxmox.com>
Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
---
 src/PVE/RESTEnvironment.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/RESTEnvironment.pm b/src/PVE/RESTEnvironment.pm
index 191c6eb..41efb16 100644
--- a/src/PVE/RESTEnvironment.pm
+++ b/src/PVE/RESTEnvironment.pm
@@ -723,7 +723,7 @@ sub log_warn {
 	$rest_env->warn($message);
     } else {
 	chomp($message);
-	print STDERR "WARN: $message\n";
+	warn "WARN: $message\n";
     }
 }
 
@@ -732,7 +732,7 @@ sub warn {
 
     chomp($message);
 
-    print STDERR "WARN: $message\n";
+    warn "WARN: $message\n";
 
     $self->{warning_count}++;
 }
-- 
2.39.2