[pve-devel] [PATCH qemu-server v3 1/4] api: delete unused OVF.pm

Dominik Csapak d.csapak at proxmox.com
Mon Apr 29 13:21:12 CEST 2024


the api part was never in use by anything

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
 PVE/API2/Qemu/Makefile |  2 +-
 PVE/API2/Qemu/OVF.pm   | 53 ------------------------------------------
 2 files changed, 1 insertion(+), 54 deletions(-)
 delete mode 100644 PVE/API2/Qemu/OVF.pm

diff --git a/PVE/API2/Qemu/Makefile b/PVE/API2/Qemu/Makefile
index bdd4762b..5d4abda6 100644
--- a/PVE/API2/Qemu/Makefile
+++ b/PVE/API2/Qemu/Makefile
@@ -1,4 +1,4 @@
-SOURCES=Agent.pm CPU.pm Machine.pm OVF.pm
+SOURCES=Agent.pm CPU.pm Machine.pm
 
 .PHONY: install
 install:
diff --git a/PVE/API2/Qemu/OVF.pm b/PVE/API2/Qemu/OVF.pm
deleted file mode 100644
index cc0ef2da..00000000
--- a/PVE/API2/Qemu/OVF.pm
+++ /dev/null
@@ -1,53 +0,0 @@
-package PVE::API2::Qemu::OVF;
-
-use strict;
-use warnings;
-
-use PVE::JSONSchema qw(get_standard_option);
-use PVE::QemuServer::OVF;
-use PVE::RESTHandler;
-
-use base qw(PVE::RESTHandler);
-
-__PACKAGE__->register_method ({
-    name => 'readovf',
-    path => '',
-    method => 'GET',
-    proxyto => 'node',
-    description => "Read an .ovf manifest.",
-    protected => 1,
-    parameters => {
-	additionalProperties => 0,
-	properties => {
-	    node => get_standard_option('pve-node'),
-	    manifest => {
-		description => "Path to .ovf manifest.",
-		type => 'string',
-	    },
-	},
-    },
-    returns => {
-	type => 'object',
-	additionalProperties => 1,
-	properties => PVE::QemuServer::json_ovf_properties(),
-	description => "VM config according to .ovf manifest.",
-    },
-    code => sub {
-	my ($param) = @_;
-
-	my $manifest = $param->{manifest};
-	die "check for file $manifest failed - $!\n" if !-f $manifest;
-
-	my $parsed = PVE::QemuServer::OVF::parse_ovf($manifest);
-	my $result;
-	$result->{cores} = $parsed->{qm}->{cores};
-	$result->{name} =  $parsed->{qm}->{name};
-	$result->{memory} = $parsed->{qm}->{memory};
-	my $disks = $parsed->{disks};
-	for my $disk (@$disks) {
-	    $result->{$disk->{disk_address}} = $disk->{backing_file};
-	}
-	return $result;
-    }});
-
-1;
-- 
2.39.2





More information about the pve-devel mailing list