[pve-devel] applied: [PATCH pve-installer] answer: perform basic input validation for keyboard

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Apr 24 11:34:25 CEST 2024


Am 24/04/2024 um 10:48 schrieb Christian Ebner:
> Currently it is possible to validate and create an iso with an
> invalid keyboad layout, only failing later during installation.
> 
> Add a basic check for correct keyboard layout by defining an enum
> with allowed variants.
> 
> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> ---
>  proxmox-auto-installer/src/answer.rs | 39 +++++++++++++++++++++++++++-
>  proxmox-auto-installer/src/utils.rs  |  8 ++++--
>  2 files changed, 44 insertions(+), 3 deletions(-)
> 
>

applied, with a follow-up to use serde_plain::derive_display_from_serialize
to derive the Display impl, thanks!

btw. if we probably want to use the same perl code that generates the valid
list for the installer environment to output that at build time in such a
way that we can source it from rust on build.




More information about the pve-devel mailing list