[pve-devel] [PATCH storage] plugin: move definition for 'port' option to base plugin

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Apr 18 10:15:27 CEST 2024


Am 18/04/2024 um 09:38 schrieb Fiona Ebner:
> I was thinking, users might stumble upon this e.g. with "man pvesm", and
> then try it for storages like NFS and wonder why it doesn't work. With
> the "options" option we also explicitly mention NFS/CIFS. I'll send a v2
> without mentioning PBS/ESXi if you still want me to after reading my
> rationale (should remember to also mention such seemingly little things
> in the commit message).

Yeah, some users might indeed be confused about NFS or the like..
how about adding this info at the end and as example, to avoid conveying
that this is a definitive list, e.g.: "... (for example, PBS or ESXi)"?




More information about the pve-devel mailing list