[PATCH v2 access-control] fix #5335: stable sorting in user.cfg

Daniel Krambrock krambrock at hrz.uni-marburg.de
Tue Apr 16 09:27:05 CEST 2024


Stable sorting in user.cfg config file allows tracking changes by
checking into git or when using automation like ansible.

Signed-off-by: Daniel Krambrock <krambrock at hrz.uni-marburg.de>
---
 changes since v1:
 * added commit message

 src/PVE/AccessControl.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm
index 21f93ff..47f2d38 100644
--- a/src/PVE/AccessControl.pm
+++ b/src/PVE/AccessControl.pm
@@ -951,7 +951,7 @@ sub iterate_acl_tree {
 
     my $children = $node->{children};
 
-    foreach my $child (keys %$children) {
+    foreach my $child (sort keys %$children) {
 	iterate_acl_tree("$path/$child", $children->{$child}, $code);
     }
 }
-- 
2.39.2




More information about the pve-devel mailing list