[pve-devel] [PATCH qemu-server v2 2/2] drive: improve readability to get_scsi_device_type

Hannes Duerr h.duerr at proxmox.com
Wed Apr 10 13:17:30 CEST 2024


Signed-off-by: Hannes Duerr <h.duerr at proxmox.com>
---
 PVE/API2/Qemu.pm        | 2 +-
 PVE/QemuServer.pm       | 2 +-
 PVE/QemuServer/Drive.pm | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index 497987f..dc44dee 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -751,7 +751,7 @@ sub assert_scsi_feature_compatibility {
     my $machine_type = PVE::QemuServer::get_vm_machine($conf, undef, $conf->{arch});
     my $machine_version = PVE::QemuServer::Machine::extract_version(
 	$machine_type, PVE::QemuServer::kvm_user_version());
-    my $drivetype = PVE::QemuServer::Drive::get_scsi_devicetype(
+    my $drivetype = PVE::QemuServer::Drive::get_scsi_device_type(
 	$drive, $storecfg, $machine_version);
 
     if ($drivetype ne 'hd' && $drivetype ne 'cd') {
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 6e2c805..bd375a2 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -1413,7 +1413,7 @@ sub print_drivedevice_full {
 	my $unit = $drive->{index} % $maxdev;
 
 	my $machine_version = extract_version($machine_type, kvm_user_version());
-	my $devicetype  = PVE::QemuServer::Drive::get_scsi_devicetype(
+	my $devicetype  = PVE::QemuServer::Drive::get_scsi_device_type(
 	    $drive, $storecfg, $machine_version);
 
 	if (!$conf->{scsihw} || $conf->{scsihw} =~ m/^lsi/ || $conf->{scsihw} eq 'pvscsi') {
diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm
index c829bde..6a4fafd 100644
--- a/PVE/QemuServer/Drive.pm
+++ b/PVE/QemuServer/Drive.pm
@@ -848,7 +848,7 @@ sub path_is_scsi {
     return $res;
 }
 
-sub get_scsi_devicetype {
+sub get_scsi_device_type {
     my ($drive, $storecfg, $machine_version) = @_;
 
     my $devicetype = 'hd';
-- 
2.39.2





More information about the pve-devel mailing list