[pve-devel] [PATCH manager] Revert "ui: dc: remove notify key from datacenter option view"

Lukas Wagner l.wagner at proxmox.com
Tue Apr 9 15:44:11 CEST 2024


On  2024-04-09 15:07, Thomas Lamprecht wrote:
> I'd propose two changes:
> 
> - add a hint to redirect users to the new mechanisms so that a future
>   deprecation would be more expected (if we already plan that now)
> 
> - only show it if defined? While that's a bit magic, it'd avoid that
>   users set it, but rather use the new mechanism.
>   If, I'd never delete the setting via the UI, so that it doesn't
>   suddenly disappears if one switches it from some value to default.
> 
> What do you think?

I think that would make a lot of sense. I'll send a v2 with the suggested
changes.

Thanks a lot for the feedback!

-- 
- Lukas




More information about the pve-devel mailing list