[pve-devel] [PATCH proxmox-firewall 09/37] config: firewall: add types for rules

Stefan Hanreich s.hanreich at proxmox.com
Tue Apr 9 10:36:05 CEST 2024


On 4/3/24 12:46, Max Carrara wrote:
> Hmm, since this is only used below, IMO it's fine that this returns a
> tuple like that on `Ok` - but should functions like that be used in
> multiple places, it might be beneficial to use a type alias or even a
> tuple struct for readability's sake.

Yes, I figured it was alright in this case, since it's mostly its own
function so the FromStr implementation is less noisy

> Should maaaybe note that it must be sorted for binary search, not just
> for any reason. :P

Will do!




More information about the pve-devel mailing list