[pve-devel] applied-series: [PATCH v3 stable-7+master manager 1/3] ui: vm selector: gracefully handle empty IDs in setValue function

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Sep 27 19:22:46 CEST 2023


Am 25/09/2023 um 13:58 schrieb Fiona Ebner:
> An empty string is passed by the backup job window when using
> selection mode 'all', would be converted to [""] and wrongly add an
> entry with VMID 0 because the item "" could not be found in the store.
> 
> Reported in the community forum:
> https://forum.proxmox.com/threads/130164/
> 
> Fixes: 7a5ca76a ("fix #4239: ui: show selected but non-existing vmids in backup edit")
> Suggested-by: Dominik Csapak <d.csapak at proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
> 
> It is enough to apply this or the second patch to stable-7 to fix the
> issue.
> 
> Changes in v3:
>     * use filter function to handle more general cases like "100,,200"
>       and not just the empty string.
> 
>  www/manager6/form/VMSelector.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied series and the first one also to stable-7, thanks!

ps. you got my OK for applying your own patches if there was positive
review/testing feedback.





More information about the pve-devel mailing list