[pve-devel] [PATCH v2 pve-manager 2/2] ui: qemu : memoryedit: add new max && virtio fields

[Thomas Lamprecht]

Am 02/09/2023 um 08:18 schrieb DERUMIER, Alexandre:
> Le vendredi 01 septembre 2023 à 12:24 +0200, Fiona Ebner a écrit :
>> Am 01.09.23 um 11:48 schrieb Thomas Lamprecht:
>>> Am 19/06/2023 um 09:28 schrieb Alexandre Derumier:
>>>> +               xtype: 'pveMemoryField',
>>>> +               name: 'max',
>>>> +               minValue: 65536,
>>>> +               maxValue: 4194304,
>>>> +               value: '',
>>>> +               step: 65536,
>>>> +               fieldLabel: gettext('Maximum memory') + ' (MiB)',
>>> This huge step size will be confusing to users, there should be a
>>> way to have
>>> smaller steps (e.g., 1 GiB or even 128 MiB).
>>>
>>> As even nowadays, with a huge amount of installed memory on a lot
>>> of servers,
>>> deciding that a (potentially bad actor) VM can use up 64G or 128G
>>> is still
>>> quite the difference on a lot of setups. Fiona is checking the
>>> backend here
>>> to see if it might be done with a finer granularity, or what other
>>> options
>>> we have here.
>>>
> I was not think about max size as a security feature, but more to
> define the min dimm size to reach this max value.

Hmm, then I'd might it easier to understand if this is named "DIMM Size"
or "Minimal DIMM-Size", for the UI we could show the resulting max-memory
that one can achieve with each DIMM-Size selected.

The range could be from 128 MB to 64 GB (or higher?), and yeah if we have
an actual maximum we could also auto-calculate it, if not set explicitly
by the user.

But, I'm currently not to deep into this topic, so take my suggestions
with a grain of salt.