[pve-devel] [PATCH-SERIES qemu-server] avoid cyclic use of main module in memory module

Fiona Ebner f.ebner at proxmox.com
Mon Sep 4 13:39:44 CEST 2023


Mostly cleanup, moving some code out of the main module and as
indirect preparation for Alexandre's series reworking memory hotplug
[0]. At one point during development, the cyclic use caused actual
problems [1]. Let's avoid any future surprises caused by the cyclic
use and get rid of it.

Also includes the first patch of Alexandre's series, because that
gets rid of the PVE::QemuServer::defaults() call.

Because of that patch a versioned Breaks for pve-ha-manager < 4.0.1 is
needed, because earlier versions don't expect a property string.

[0]: https://lists.proxmox.com/pipermail/pve-devel/2023-June/057690.html
[1]: https://lists.proxmox.com/pipermail/pve-devel/2023-January/055356.html


Alexandre Derumier (1):
  add memory parser

Fiona Ebner (4):
  move parse_number_sets() helper to helpers module
  move NUMA-related code into memory module
  memory: replace deprecated check_running() call
  introduce QMPHelpers module

 PVE/API2/Qemu.pm             |   7 +-
 PVE/QemuConfig.pm            |   8 +-
 PVE/QemuMigrate.pm           |   6 +-
 PVE/QemuServer.pm            | 123 +++++--------------------------
 PVE/QemuServer/Helpers.pm    |  18 ++++-
 PVE/QemuServer/Makefile      |   1 +
 PVE/QemuServer/Memory.pm     | 138 +++++++++++++++++++++++++++++------
 PVE/QemuServer/QMPHelpers.pm |  48 ++++++++++++
 8 files changed, 208 insertions(+), 141 deletions(-)
 create mode 100644 PVE/QemuServer/QMPHelpers.pm

-- 
2.39.2






More information about the pve-devel mailing list