[pve-devel] applied: [PATCH v2 qemu] add fix for vnc clipboard

[Thomas Lamprecht]

Am 22/11/2023 um 13:41 schrieb Fiona Ebner:
> This fixes the host->guest direction with noNVC as a client (and
> likely others).
> 
> Reported-by: Friedrich Weber <f.weber at proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
>  ...-ui-vnc-clipboard-fix-inflate_buffer.patch | 34 +++++++++++++++++++
>  debian/patches/series                         |  1 +
>  2 files changed, 35 insertions(+)
>  create mode 100644 debian/patches/extra/0010-ui-vnc-clipboard-fix-inflate_buffer.patch
> 

applied, with Friedrich's T-b, thanks!

> +diff --git a/ui/vnc-clipboard.c b/ui/vnc-clipboard.c
> +index c759be3438..124b6fbd9c 100644
> +--- a/ui/vnc-clipboard.c
> ++++ b/ui/vnc-clipboard.c
> +@@ -69,6 +69,11 @@ static uint8_t *inflate_buffer(uint8_t *in, uint32_t in_len, uint32_t *size)
> +         }
> +     }
> + 

could be a bit nicer to have a "stream_end" label here that you goto
from the Z_STREAM_END case too, making it slightly clearer how those
two cases interact (i.e., are handled exactly the same). But not
much into QEMU code (style) currently, so lets upstream handle the
review on that one, it works in any case.

> ++    *size = stream.total_out;
> ++    inflateEnd(&stream);
> ++
> ++    return out;