[pve-devel] [PATCH v3 pve-manager 4/5] ui: backup: add 'notification-mode' param for one-shot backup jobs.

Lukas Wagner l.wagner at proxmox.com
Tue Nov 21 13:42:08 CET 2023



On 11/21/23 13:38, Philipp Hufnagl wrote:
>> +	let notificationModeSelector = Ext.create({
>> +	    xtype: 'proxmoxKVComboBox',
>> +	    comboItems: [
>> +		['auto', gettext('Auto')],
>> +		['legacy-sendmail', gettext('Email (legacy)')],
>> +		['notification-system', gettext('Notification system')],
>> +	    ],
>> +	    fieldLabel: gettext('Notification mode'),
>> +	    name: 'notification-mode',
>> +	    value: 'auto',
>> +	    listeners: {
>> +		change: function(field, value) {
>> +		    mailtoField.setDisabled(value === 'notification-system');
>> +		}
>> +	    }
>> +	});
>> +
> 
> nit: you missed the commas on 52 on 53

Argh, thx. Deployed/tested it via `make install` instead via
`make deb`, I think eslint is a bit more linient there.

-- 
- Lukas





More information about the pve-devel mailing list