[pve-devel] [PATCH v2 guest-common/manager 0/4] vzdump: add 'notification-mode' parameter

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Nov 21 13:34:53 CET 2023


Am 21/11/2023 um 13:13 schrieb Lukas Wagner:
> On 11/21/23 11:55, Fiona Ebner wrote:
>> Can't we just treat 'failure' mode as always defaulting to legacy
>> sendmail? And properly deprecate the setting, showing a warning/info
>> that new notification system is not used if set to 'failure' for both
>> CLI and UI. And maybe not even allow setting it for new jobs/manual backups?
> 
> I think an explicit switch here is much more obvious and predictable to 
> the user.
> 
> Personally I think we should wait a bit before deprecating/disallowing 
> 'mailto' for new backup jobs. This gives us time to polish the UX of
> creating matchers etc. without 'forcing' the user into the new system.
> 

I think so too, if it would be a new major release we might be a bit more
aggressive here, but for a point release we definitively should avoid
deprecation warnings, that something for next (or next next) major release,
possibly with an automated migration path for existing users (which would
have been a bit to much work to implement and test sanely in the remaining
time for next release)





More information about the pve-devel mailing list