[pve-devel] applied-series: [PATCH access-control/manager 0/4] fix #1148: nested pools

Wolfgang Bumiller w.bumiller at proxmox.com
Mon Nov 20 12:27:04 CET 2023


applied series, bumped access control and manager's dep on it

On Mon, Nov 20, 2023 at 08:22:38AM +0100, Fabian Grünbichler wrote:
> this series extends the poolname to allow (for now) two '/' inside the
> name to nest pools like this:
> 
> parent/child/grandchild
> 
> since '/' is a bad character for path parameters, some API shuffling is
> needed. other approaches that were tried but discarded, or rejected
> outright:
> - urlencoding
> - systemd-escape
> - manual encoding/escaping
> - just encoding the parent/children in user.cfg, but not in the pool name
> 
> switching over some of the UI pool lists to also nest them visually should
> be do-able as a follow-up.
> 
> changes since RFC:
> - some style improvements, RE adaptation
> 
> pve-access-control:
> 
> Fabian Grünbichler (2):
>   allow up to three levels of pool nesting
>   pools: record parent/subpool information
> 
>  src/PVE/AccessControl.pm  | 26 +++++++++++++++++++++++---
>  src/test/parser_writer.pl |  4 ++++
>  src/test/perm-test6.pl    | 16 ++++++++++++++++
>  src/test/test6.cfg        |  5 +++++
>  4 files changed, 48 insertions(+), 3 deletions(-)
> 
> pve-manager:
> 
> Fabian Grünbichler (2):
>   api: pools: support nested pools
>   ui: pools: switch to new API endpoints
> 
>  PVE/API2/Pool.pm                 | 243 +++++++++++++++++++++++--------
>  www/manager6/dc/PoolView.js      |   3 +
>  www/manager6/grid/PoolMembers.js |  14 +-
>  www/manager6/pool/StatusView.js  |   2 +-
>  4 files changed, 196 insertions(+), 66 deletions(-)
> 
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel





More information about the pve-devel mailing list