[pve-devel] [PATCH v2 many 00/52] revamp notifications; smtp endpoints; system mail

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Nov 20 10:11:59 CET 2023


Am 20/11/2023 um 10:03 schrieb Lukas Wagner:
> On 11/17/23 09:41, Dominik Csapak wrote:
>> one additional comment to the ux:
>>
>> the match field could use a bit of improvement:
>>
>> the docs describe the current fields, but for users that
>> don't deep dive into the docs first it may be confusing having
>> a simple text input field for that
>>
>> at least when the type is 'exact' we could offer a
>> dropdown for the 'type' value (can still be editable)
> 
> I'm actually evaluating if it would make sense to have a separate
> 'match-type' match rule. That one would use the 'type' field
> in the notification metadata, but would be a bit more obvious to use for 
> the user.
> 
> I think filtering notifications by type is probably going to be one of 
> the most common things a user wants to do. Right now, if a user only
> cares about a subset of notification types, e.g. backups and 
> replication, a matcher would could look like this:
> 

match-type sounds like it really could be nice, and as you say, one of the
more commonly used things.
Until there's a static (api delivered) list of known types, we could also
just document them in pve-docs, for now there aren't that many IIRC.





More information about the pve-devel mailing list