[pve-devel] applied: [PATCH installer] tui: bootdisk zfs config: add a maximum value to the `copies` option

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Nov 17 17:41:40 CET 2023


Am 17/11/2023 um 17:32 schrieb Stefan Sterz:
> according to `man zfsprops` the copies option can only be 1, 2, or 3.
> limit the field to 3, as setting higher options can't work anyway.
> 
> Signed-off-by: Stefan Sterz <s.sterz at proxmox.com>
> ---
> i would have added a `min_value` of 1 too, but `IntegerEditView` is
> based on `NumericEditView` and that doesn't offer a minimal value.
> 
>  proxmox-tui-installer/src/views/bootdisk.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, fleeced in a note that we already limit that in the GTK UI
(for the exact reason you reference), thanks!





More information about the pve-devel mailing list