[pve-devel] applied: [PATCH widget-toolkit 1/1] combogrid: initialze value with [] by default

[Thomas Lamprecht]

Am 19/07/2023 um 14:11 schrieb Dominik Csapak:
> we have to initialize the value of a combogrid to something (else extjs
> does not initialize everything in the object *sometimes* for yet unknown
> reasons), but the empty string is wrong.
> 
> we already have at least two places where we set the default value to []
> (namely NodeSelector and ha GroupSelector) with the comment:
> 
>  // set default value to empty array, else it inits it with
>  // null and after the store load it is an empty array,
>  // triggering dirtychange
> 
> so it makes sense to always set it to that by default. This only ever is
> relevant when the combogrid has `allowBlank: true`, since if it does not
> it's either invalid (and thus "dirty") or it has a selected value anyway
> 
> this should make the manual setting of
> 
>  value: [],
> 
> unnecessary in the child classes. We can even remove it direcly in the
> NetworkSelector.
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  src/form/ComboGrid.js       | 2 +-
>  src/form/NetworkSelector.js | 4 ----
>  2 files changed, 1 insertion(+), 5 deletions(-)
> 
>

applied, thanks!