[pve-devel] [PATCH manager 1/2] ui: BulkActions: rework filters and include tags

[Dominik Csapak]

On 11/8/23 13:38, Thomas Lamprecht wrote:
> Am 08/11/2023 um 13:14 schrieb Dominik Csapak:
>> On 11/6/23 17:01, Thomas Lamprecht wrote:
>>> - the CT/VM ID filter is a bit odd, especially if tuned to match all,
>>>     not only parts of the VMID (which would not be *that* much better
>>>     either IMO), when I want to migrate/start/stop a single VM I can just
>>>     do so, no need for opening the bulk actions.
>>
>> counter argument:
>>
>> if i want to migrate/start/stop a specific list of vmid it may be faster
>> if i go to the bulk window, search vmid -> select, search vmid -> select, etc.
>> than go to vm -> click stop -> go to vm -> click stop
> 
> It's faster to use the context menu of the tree or the one from the
> global search though.
> But faster is IMO the wrong thing to look at here anyway, as using
> bulk actions for a single action feels always wrong conceptually,
> so devfinitively won't be a common path for users.
> If, there would need ot be a situation when someone wants to do a bulk
> action, but circumstances change midway, after they opened the dialog,
> so that they only need to stop/start/... a single guest now.
> And even then they can still do that without the extra field (deselect
> all, select single guest).
> 
> So IMO adding a whole field for this niche use case seems rather
> overkill to me.

ok, i'll remove it

> 
>>> - tag space is very limited, maybe default to using circles or even
>>>     dense (I'm still wishing a bit for seeing the tag value on hover, like
>>>     a tool tip), or re-use the tree-style shape.
>>>     One alternative might be to add vertical scrolling here, but that is
>>>     probably rather odd (and not sure if that would even work easily
>>>     here).
>>
>> scrolling in two dimensions for different containers is always a bit weird
>> imho, but yeah making the tags 'dense' 'circle' or reusing the treestyle makes sense
> 
> Yeah, additional scrolling is indeed not the nicest thing to add here.
> 
>>
>> i agree with the tooltip, but last time i looked at it that was not so easy
>> because we already have a tooltip in the tree (and we reuse the rendering
>> for that) but i could see if i could add a tooltip to the whole cell
>> here that prints all tags in a nice way, what do you think?
> 
> I mean, for here there would not be a tool tip yet and we could have
> slightly different behavior here than in the tree any way.
> 
> But for the tree: How about reducing the scope of the current status
> tooltip from the whole row to the icon + text part only, so tags can
> have a separate, per tag one.

sadly including the icon is only possible if we overwrite the whole template of the treecolumn
here, since the icon div is seperated from the text div without a possibility
to set additional data there

(you can check out the template here: 
https://docs.sencha.com/extjs/7.0.0/classic/src/Column.js-2.html maybe you see a way to do this easier?)