[pve-devel] [PATCH proxmox-widget-toolkit 22/27] notification ui: remove filter setting for targets

Lukas Wagner l.wagner at proxmox.com
Tue Nov 7 11:18:22 CET 2023


Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
---
 src/Makefile                            |  1 -
 src/form/NotificationFilterSelector.js  | 58 -------------------------
 src/panel/GotifyEditPanel.js            |  9 ----
 src/panel/NotificationGroupEditPanel.js |  9 ----
 src/panel/SendmailEditPanel.js          |  9 ----
 5 files changed, 86 deletions(-)
 delete mode 100644 src/form/NotificationFilterSelector.js

diff --git a/src/Makefile b/src/Makefile
index 21fbe76..85ecea4 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -44,7 +44,6 @@ JSSRC=					\
 	form/RoleSelector.js		\
 	form/DiskSelector.js		\
 	form/MultiDiskSelector.js	\
-	form/NotificationFilterSelector.js	\
 	form/TaskTypeSelector.js	\
 	form/ACME.js			\
 	form/UserSelector.js		\
diff --git a/src/form/NotificationFilterSelector.js b/src/form/NotificationFilterSelector.js
deleted file mode 100644
index d2ab8be..0000000
--- a/src/form/NotificationFilterSelector.js
+++ /dev/null
@@ -1,58 +0,0 @@
-Ext.define('Proxmox.form.NotificationFilterSelector', {
-    extend: 'Proxmox.form.ComboGrid',
-    alias: ['widget.pmxNotificationFilterSelector'],
-
-    // set default value to empty array, else it inits it with
-    // null and after the store load it is an empty array,
-    // triggering dirtychange
-    value: [],
-    valueField: 'name',
-    displayField: 'name',
-    deleteEmpty: true,
-    skipEmptyText: true,
-    allowBlank: true,
-    editable: false,
-    autoSelect: false,
-
-    listConfig: {
-	columns: [
-	    {
-		header: gettext('Filter'),
-		dataIndex: 'name',
-		sortable: true,
-		hideable: false,
-		flex: 1,
-	    },
-	    {
-		header: gettext('Comment'),
-		dataIndex: 'comment',
-		sortable: true,
-		hideable: false,
-		flex: 2,
-	    },
-	],
-    },
-
-    initComponent: function() {
-	let me = this;
-
-	Ext.apply(me, {
-	    store: {
-		fields: ['name', 'comment'],
-		proxy: {
-		    type: 'proxmox',
-		    url: `/api2/json/${me.baseUrl}/filters`,
-		},
-		sorters: [
-		    {
-			property: 'name',
-			direction: 'ASC',
-		    },
-		],
-		autoLoad: true,
-	    },
-	});
-
-	me.callParent();
-    },
-});
diff --git a/src/panel/GotifyEditPanel.js b/src/panel/GotifyEditPanel.js
index 3ddcc4d..5d814e5 100644
--- a/src/panel/GotifyEditPanel.js
+++ b/src/panel/GotifyEditPanel.js
@@ -32,15 +32,6 @@ Ext.define('Proxmox.panel.GotifyEditPanel', {
 		allowBlank: '{!isCreate}',
 	    },
 	},
-	{
-	    xtype: 'pmxNotificationFilterSelector',
-	    name: 'filter',
-	    fieldLabel: gettext('Filter'),
-	    cbind: {
-		deleteEmpty: '{!isCreate}',
-		baseUrl: '{baseUrl}',
-	    },
-	},
 	{
 	    xtype: 'proxmoxtextfield',
 	    name: 'comment',
diff --git a/src/panel/NotificationGroupEditPanel.js b/src/panel/NotificationGroupEditPanel.js
index aa76810..910d15a 100644
--- a/src/panel/NotificationGroupEditPanel.js
+++ b/src/panel/NotificationGroupEditPanel.js
@@ -21,15 +21,6 @@ Ext.define('Proxmox.panel.NotificationGroupEditPanel', {
 	    name: 'endpoint',
 	    allowBlank: false,
 	},
-	{
-	    xtype: 'pmxNotificationFilterSelector',
-	    name: 'filter',
-	    fieldLabel: gettext('Filter'),
-	    cbind: {
-		deleteEmpty: '{!isCreate}',
-		baseUrl: '{baseUrl}',
-	    },
-	},
 	{
 	    xtype: 'proxmoxtextfield',
 	    name: 'comment',
diff --git a/src/panel/SendmailEditPanel.js b/src/panel/SendmailEditPanel.js
index ace6129..16abebc 100644
--- a/src/panel/SendmailEditPanel.js
+++ b/src/panel/SendmailEditPanel.js
@@ -86,15 +86,6 @@ Ext.define('Proxmox.panel.SendmailEditPanel', {
 		return this.up('pmxSendmailEditPanel').mailValidator();
 	    },
 	},
-	{
-	    xtype: 'pmxNotificationFilterSelector',
-	    name: 'filter',
-	    fieldLabel: gettext('Filter'),
-	    cbind: {
-		deleteEmpty: '{!isCreate}',
-		baseUrl: '{baseUrl}',
-	    },
-	},
 	{
 	    xtype: 'proxmoxtextfield',
 	    name: 'comment',
-- 
2.39.2






More information about the pve-devel mailing list