[pve-devel] [PATCH access-control] ldap: fix ldap distinguished names regex

Thomas Lamprecht t.lamprecht at proxmox.com
Sun May 28 19:50:59 CEST 2023


Am 17/05/2023 um 15:42 schrieb Stefan Sterz:
> sorry just noticed i forgot: adding tests for this was
> 
> Suggested-by: Dominik Csapak <d.csapak at proxmox.com>

I mean, it's really great that we finally get some tests here and if only
Dominik statement made you do it, then chapeau to him! But, Suggested-by's
should be mostly for suggestion on implementation (details), as you all
definitively have a blanket statement from me, and I'd think it's safe to say
also from all other maintainers, to add tests!

I mean, great if that was all needed to solve the motivation to write tests
in developers ;-P







More information about the pve-devel mailing list