[pve-devel] applied: [PATCH manager 0/7] backup edit window improvements

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Mar 14 11:37:00 CET 2023


Am 06/03/2023 um 15:23 schrieb Dominik Csapak:
> two bugfixes (the VMSelector changes are necessary for those)
> and a refactor of the edit window (i put that patch at the end, because even
> with simplifications, it's still ~30 lines more, and i was not sure if that's
> worth it)
> 
> Dominik Csapak (7):
>   ui: VMSelector: columns customizable
>   ui: VMSelector: improve {set,get}Value handling with a loading store
>   ui: VMSelector: change from filter to load parameters
>   ui: VMSelector: correctly change invalid class on en/disable
>   fix #4490: ui: add column filters in Backup Job edit window
>   fix #4239: ui: show selected but non-existing vmids in backup edit
>   ui: BackupEdit: refactor edit window into declarative style
> 
>  www/manager6/dc/Backup.js       | 788 +++++++++++++++-----------------
>  www/manager6/form/VMSelector.js |  75 ++-
>  2 files changed, 423 insertions(+), 440 deletions(-)
> 


applied series, albeit I wanted to look a bit more closely onto it but my finger
slipped, anyhow, the core idea is good and any regression we can fix, so thanks!





More information about the pve-devel mailing list