[pve-devel] [PATCH pve-cluster] pve-cluster.service : remove 127.0.1.1 from /etc/hosts

[Thomas Lamprecht]

Am 28/06/2023 um 08:06 schrieb Alexandre Derumier:
> stock debian or some hosting company like ovh through cloudinit at each boot,
> add 127.0.1.1 <hostname> in /etc/hosts.

Yeah, tools just messing with /etc/hosts et al. is irritating..

> 
> This is breaking pve-cluster start.
> 
> fix:
> https://forum.proxmox.com/threads/proxmox-7-to-8-upgrade-problem-ovh.129678/
> https://forum.proxmox.com/threads/update-7-to-8-issue-with-cloud-init.129669/#post-568172
> https://forum.proxmox.com/threads/bookworm-installation-fails-with-pve-manager-dependency-error.129398/#post-568290
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> ---
>  debian/pve-cluster.service | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian/pve-cluster.service b/debian/pve-cluster.service
> index 4327055..f6bdac2 100644
> --- a/debian/pve-cluster.service
> +++ b/debian/pve-cluster.service
> @@ -14,6 +14,7 @@ Before=shutdown.target
>  Conflicts=shutdown.target
>  
>  [Service]
> +ExecStartPre=/usr/bin/sed -i '/127.0.1.1/d' /etc/hosts

.. and so is this, messing with hosts on every  pve-cluster start or update..

So no, please don't, messing with such things can be really subtle!

Let's rather improve pmxcfs logic for getting the non-local IP configured on
a node via getaddrinfo with the ALL flag and filtering out local IPs..

>  ExecStart=/usr/bin/pmxcfs
>  KillMode=mixed
>  Restart=on-failure