[pve-devel] applied: [PATCH installer] tui: switch to `f64` for disk sizes

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jun 22 14:36:08 CEST 2023


Am 22/06/2023 um 11:20 schrieb Stefan Sterz:
> previously the tui used `u64` internally to represent the disk size.
> since the perl-based installer expects GiB as floats and that is also
> what is displayed in the tui that meant a lot of converting back and
> forth. it also lead to an error where the disk sizes that were set
> seemed to not have been persisted, even though the sizes were
> correctly set. this commit refactors the installer to convert the size
> once in the beginning and then stick to `f64`.
> 
> Signed-off-by: Stefan Sterz <s.sterz at proxmox.com>
> ---
>  proxmox-tui-installer/src/options.rs   | 26 ++++++++++++--------------
>  proxmox-tui-installer/src/setup.rs     | 16 ++++++++--------
>  proxmox-tui-installer/src/views/mod.rs | 18 +++++++-----------
>  3 files changed, 27 insertions(+), 33 deletions(-)
> 
>

applied, with Christophs T-b and R-b, thanks!





More information about the pve-devel mailing list