[pve-devel] [PATCH v4 qemu-server 2/12] qemuserver: foreach_volid: include pending volumes

[Thomas Lamprecht]

Am 16/06/2023 um 14:25 schrieb Fiona Ebner:
>> @@ -4902,6 +4904,11 @@ sub foreach_volid {
>>      };
>>  
>>      PVE::QemuConfig->foreach_volume_full($conf, $include_opts, $test_volid);
>> +
>> +    if ($include_pending && defined($conf->{pending}) && $conf->{pending}->%*) {
>> +	PVE::QemuConfig->foreach_volume_full($conf->{pending}, $include_opts, $test_volid, undef, 1);
>> +    }
>
> Style nit: wouldn't be 101 chars as a post-if 😉

OTOH, the check is a bit complex and for complex ones the "normal" if block
often feels a bit easier to read, but not really hard feelings either way ^^