[pve-devel] [PATCH qemu-server] fix #4549: capture and bubble up qemu errors correctly

Fiona Ebner f.ebner at proxmox.com
Mon Jun 12 13:26:57 CEST 2023


Am 12.06.23 um 13:22 schrieb Fiona Ebner:
> Am 09.05.23 um 10:46 schrieb Christoph Heiss:
>> +	    my $err = '';
>> +	    $run_params{logfunc} = sub { $err .= "QEMU: $1\r\n"; };
> 
> Style nit: please use $run_params->{logfunc}

Please ignore me here, didn't realize it wasn't a hash reference, but a
hash at first. I guess it wouldn't just be style otherwise :)





More information about the pve-devel mailing list