[pve-devel] applied: Re: [PATCH v4 qemu-server 1/1] api2: add check_bridge_access for create/update/clone/restore vm

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jun 8 18:02:58 CEST 2023


On 07/06/2023 14:03, Alexandre Derumier wrote:
> Signed-off-by: Alexandre Derumier <aderumier at odiso.com>
> ---
>  PVE/API2/Qemu.pm | 33 +++++++++++++++++++++++++++++----
>  1 file changed, 29 insertions(+), 4 deletions(-)
> 
>

applied, with Fabians R-b, thanks.

Made a follow-up moving the checker method to QemuServer and replacing getting
the config fromthe archive twice by checking after the config from the backup
and the override pa<rameters passed on restore got merged into the actual target
config, so this wasn't only a inefficiency thing IIUC, but actually wrong, i.e.,
if one passed a override for a netX property the one from the backup got checked,
not the effective one.





More information about the pve-devel mailing list