[pve-devel] applied: [PATCH qemu-server] fix #3428: cloudinit: add parameter for upgrade on boot

[Thomas Lamprecht]

Am 04/05/2023 um 12:55 schrieb Leo Nunner:
> up until now, we did an automatic upgrade after the first boot in our
> standard cloud-init config. This has been requested to be toggleable
> several times [1][2]. With this patch, "package_upgrade" is disabled by
> default, and needs to be enabled manually, diverging from the previous
> behaviour.
> 
> [1] https://forum.proxmox.com/threads/how-to-prevent-automatic-apt-upgrade-during-the-first-boot-with-cloud-init.68472/
> [2] https://forum.proxmox.com/threads/cloud-init-ohne-package-upgrade.123841/
> 
> Signed-off-by: Leo Nunner <l.nunner at proxmox.com>
> ---
>  PVE/QemuServer.pm           | 5 +++++
>  PVE/QemuServer/Cloudinit.pm | 2 +-
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
>

applied, thanks!

> diff --git a/PVE/QemuServer/Cloudinit.pm b/PVE/QemuServer/Cloudinit.pm
> index a0c3d60..10962b5 100644
> --- a/PVE/QemuServer/Cloudinit.pm
> +++ b/PVE/QemuServer/Cloudinit.pm
> @@ -146,7 +146,7 @@ sub cloudinit_userdata {
>  	$content .= "  - default\n";
>      }
>  
> -    $content .= "package_upgrade: true\n";
> +    $content .= "package_upgrade: true\n" if $conf->{ciupgrade};

should false get rather spelled out too? i.e., if CI changes the default here someday?

No hard feelings and can be easily followed-up though..

>  
>      return $content;
>  }