[pve-devel] [PATCH v4 pve-manager 42/69] test: fix names of .PHONY targets

Wolfgang Bumiller w.bumiller at proxmox.com
Mon Jul 24 15:59:23 CEST 2023


this one I applied

On Thu, Jul 20, 2023 at 04:32:09PM +0200, Lukas Wagner wrote:
> They need to have the same name as the target.
> Took the opportunity to move the .PHONY right next to the target recipe,
> so that mistakes like these are hopefully easier caught.
> 
> Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
> ---
>  test/Makefile | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/test/Makefile b/test/Makefile
> index 670a3611..cccdc1c9 100644
> --- a/test/Makefile
> +++ b/test/Makefile
> @@ -4,29 +4,35 @@ all:
>  
>  export PERLLIB=..
>  
> -.PHONY: check balloon-test replication-test mail-test vzdump-test
> +.PHONY: check
>  check: test-replication test-balloon test-mail test-vzdump test-osd
>  
> +.PHONY: test-balloon
>  test-balloon:
>  	./balloontest.pl
>  
> +.PHONY: test-replication
>  test-replication: replication1.t replication2.t replication3.t replication4.t replication5.t replication6.t
>  
>  replication%.t: replication_test%.pl
>  	./$<
>  
> +.PHONY: test-mail
>  test-mail:
>  	./mail_test.pl
>  
> +.PHONY: test-vzdump
>  test-vzdump: test-vzdump-guest-included test-vzdump-new
>  
> -.PHONY: test-vzdump-guest-included test-vzdump-new
> +.PHONY: test-vzdump-guest-included
>  test-vzdump-guest-included:
>  	./vzdump_guest_included_test.pl
>  
> +.PHONY: test-vzdump-new
>  test-vzdump-new:
>  	./vzdump_new_test.pl
>  
> +.PHONY: test-osd
>  test-osd:
>  	./OSD_test.pl
>  
> -- 
> 2.39.2





More information about the pve-devel mailing list