[pve-devel] applied: [PATCH installer v2] tui: fix FQDN validation

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Jul 21 16:20:35 CEST 2023


On 19/07/2023 18:31, Christoph Heiss wrote:
> Add checks to ensure that:
>  * It is actually has a hostname, not just a domain name
>  * Properly check if the hostname is purely numeric, which was
>    broken/different to how the GUI installer does it
> 
> The custom error type also allows for easier future adaptions, as the
> changes can be entirely contained to the `Fqdn` type.
> 
> Signed-off-by: Christoph Heiss <c.heiss at proxmox.com>
> ---
> v1: https://lists.proxmox.com/pipermail/pve-devel/2023-June/057845.html
> 
> Changes v1 -> v2:
>  * Fix & add some more unit tests
>  * Add custom error type `FqdnParseError`
>  * Move hostname checks directly into `Fqdn::from()`
> 
>  proxmox-tui-installer/src/main.rs  |  5 +--
>  proxmox-tui-installer/src/utils.rs | 68 ++++++++++++++++++++++++------
>  2 files changed, 57 insertions(+), 16 deletions(-)
> 
>

applied, thanks!





More information about the pve-devel mailing list