[pve-devel] applied: [PATCH qemu-server 2/2] fix #4620: cfg2cmd: drive device: correctly handle IDE for q35

[Thomas Lamprecht]

On 20/07/2023 11:45, Fiona Ebner wrote:
> Only unit 0 for IDE is supported with machine type q35. Currently,
> QEMU will fail startup with machine type q35 with an error like
>> Can't create IDE unit 1, bus supports only 1 units
> when ide1 or ide3 is configured.
> 
> Make sure to keep backwards compat form migration by leaving ide0 and
> ide2 fixed. Since starting with ide1 or ide3 never worked, they can be
> moved to a controller with a higher ID without issue.
> 
> Reported in the community forum:
> https://forum.proxmox.com/threads/124615/post-543127
> https://forum.proxmox.com/threads/130815/
> 
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
> 
> For PVE 9, we could simplify the mapping to N -> controller=N,unit=0
> while version guarding with running QEMU machine version. Might be
> slightly nicer, but it'd add an extra conditional, so probably not
> worth it.
> 
>  PVE/QemuServer.pm             | 11 +++++++++++
>  test/cfg2cmd/q35-ide.conf.cmd |  4 ++--
>  2 files changed, 13 insertions(+), 2 deletions(-)
> 
>

applied, thanks!