[pve-devel] [PATCH qemu-server 1/2] qmeventd: improve getting vmid from PID in presence of legacy cgroup entries

[Fiona Ebner]

Am 10.07.23 um 09:58 schrieb Fiona Ebner:
> On a hybrid cgroup system, the /proc/<PID>/cgroup file usually looks
> like:
> 
>> 13:pids:/qemu.slice/110.scope
>> 12:perf_event:/
>> 11:devices:/qemu.slice
>> 10:misc:/
>> 9:hugetlb:/
>> 8:freezer:/
>> 7:cpu,cpuacct:/qemu.slice/110.scope
>> 6:memory:/qemu.slice/110.scope
>> 5:rdma:/
>> 4:cpuset:/
>> 3:blkio:/qemu.slice
>> 2:net_cls,net_prio:/
>> 1:name=systemd:/qemu.slice/110.scope
>> 0::/qemu.slice/110.scope
> 
> but after 'umount /sys/fs/cgroup/pids' or for other reasons, it could
> happen that an entry like '11:devices:/qemu.slice' is the first to
> match the '/qemu.slice' part, which previously made the code expect to
> find the VMID.
> 
> To improve detection, as a first step, match the trailing slash too.
> 
> Reported in the community forum:
> https://forum.proxmox.com/threads/129320/post-571654
> 
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>

I'll send a v2 with a bit more. Sorry for the noise.