[pve-devel] applied: [PATCH pve-manager v4] fix #4551: ui: use gettext on hardcoded byte units

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Jul 5 09:14:28 CEST 2023


Am 03/07/2023 um 14:15 schrieb Noel Ullreich:
> Since some languages translate byte units like 'GiB' or write them in their
> own script, this patch wraps units in the `gettext` function.
> 
> While most occurrences of byte strings can be translated within the
> `format_size` function in `proxmox-widget-toolkit/src/Utils.js`, this patch
> catches those instances that are not translated.
> 
> Signed-off-by: Noel Ullreich <n.ullreich at proxmox.com>
> ---
> changes from v1:
> * improved commit messages
> * put hardcoded byte unit strings in a template string
> 
> changes from v2:
> * rebased the patch
> 
> changges from v3:
> * rebased the patch
> 
>  www/manager6/ceph/OSD.js                 | 4 ++--
>  www/manager6/form/DiskStorageSelector.js | 2 +-
>  www/manager6/lxc/MPResize.js             | 2 +-
>  www/manager6/qemu/HDResize.js            | 2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
> 
>

applied, thanks!





More information about the pve-devel mailing list