[pve-devel] [PATCH installer v2 2/7] gui: expand ip address Gtk3::Entry

Christoph Heiss c.heiss at proxmox.com
Wed Dec 20 10:40:20 CET 2023


On Fri, Dec 15, 2023 at 03:08:48PM +0100, Maximiliano Sandoval wrote:
>
>
> Christoph Heiss <c.heiss at proxmox.com> writes:
>
> > On Tue, Nov 21, 2023 at 04:10:20PM +0100, Maximiliano Sandoval wrote:
> >>
> >> This accounts for the different layout set in the previous commit.
> >
> > What commit is meant here exactly? The previous patch in this series
> > (aka. the first) does not change any layout as it's a simple code move,
> > right?
> >
>
> Good catch, in v1 this commit went directly after the commit
>
> gui: use basic grid in the network panel

Makes sense then, I figured that.

>
> which contains the mentioned changes. Should this require a v3?

>From my side, no, if nothing else comes up. If really needed it could be
fixed up when committing at the very latest.

>
> --
> Maximiliano




More information about the pve-devel mailing list