[pve-devel] applied: [PATCH v3 storage] fix #3004: show progress of offline migration in task log

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Aug 31 15:25:10 CEST 2023


Am 31/08/2023 um 12:41 schrieb Leo Nunner:
> dd supports a 'status' flag, which enables it to show the copied bytes,
> duration, and the transfer rate, which then get printed to stderr.
> 
> Signed-off-by: Leo Nunner <l.nunner at proxmox.com>
> ---
> Changes since v2:
>     - Refactor to new repo structure
>     - Implement style changes suggested for v2
> 
>  src/PVE/Storage.pm           | 17 +++++++++++++++--
>  src/PVE/Storage/LVMPlugin.pm |  2 +-
>  src/PVE/Storage/Plugin.pm    |  4 ++--
>  3 files changed, 18 insertions(+), 5 deletions(-)
> 
>

applied, thanks!

fyi: instead of the comments I moved the $1 capture group into a $elapsed
$variable, which makes the code IMO descriptive enough without those comments.
Didn't felt that this small style nit would warrant asking a follow up from
you, so applied that directly.





More information about the pve-devel mailing list