[PATCH widget-toolkit 1/1] fixes #4874: Improve VM Name error message

[Amin Vakil]

On 8/2/23 11:46, Thomas Lamprecht wrote:
> First thanks for this patch, such polishing are important contributions!
> 
> Am 26/07/2023 um 17:36 schrieb Amin Vakil:
> 
> please add the cover letter text to the commit message so that the context is
> actually conserved in git history.
> 
> Also, for a simple single patch a cover letter is rather overhead, so you can
> omit it there.
> 
> 
>> Signed-off-by: Amin Vakil <info at aminvakil.com>
>> ---
>>   src/Toolkit.js | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/Toolkit.js b/src/Toolkit.js
>> index 67200c8..9dc28b9 100644
>> --- a/src/Toolkit.js
>> +++ b/src/Toolkit.js
>> @@ -129,12 +129,12 @@ Ext.apply(Ext.form.field.VTypes, {
>>       DnsName: function(v) {
>>   	return Proxmox.Utils.DnsName_match.test(v);
>>       },
>> -    DnsNameText: gettext('This is not a valid DNS name'),
>> +    DnsNameText: gettext('This is not a valid Host name'),
> 
> I'd not capitalize "Host" that looks odd here, it isn't an acronym after all.
> 
> Maybe even spell it together as "hostname", but no hard feelings on that part.
> 
>>   
>>       DnsNameOrWildcard: function(v) {
>>   	return Proxmox.Utils.DnsName_or_Wildcard_match.test(v);
>>       },
>> -    DnsNameOrWildcardText: gettext('This is not a valid DNS name'),
>> +    DnsNameOrWildcardText: gettext('This is not a valid Host name'),
> 
> same as above
> 
>>   
>>       // email regex used by pve-common
>>       proxmoxMail: function(v) {
> 
> 

I added information about this commit in commit message, removed the 
cover letter, also used hostname, that sounds better to me as well.

And I've sent another message now, please tell me if something else 
needs to be done.

Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 665 bytes
Desc: OpenPGP digital signature
URL: <http://lists.proxmox.com/pipermail/pve-devel/attachments/20230803/8b13c09d/attachment.sig>