[pve-devel] [PATCH manager 2/2] ui: ldap: add 'Check connection' checkbox as advanced option

[Christoph Heiss]

On Fri, Jul 28, 2023 at 10:37:12AM +0200, Lukas Wagner wrote:
>
> On Thu Jul 27, 2023 at 3:33 PM CEST, Christoph Heiss wrote:
> > The checkbox is enabled by default for new realms, setting the new
> > `check-connection` parameter.
> >
> > Won't effect existing configurations, i.e. being opt-in for them, to not
> > break existing setups.
> As mentioned in my other reply, I think setting the new parameter by default
> should not be a problem, as long as it is only in the GUI.
> >
> > --- a/www/manager6/dc/AuthEditLDAP.js
> > +++ b/www/manager6/dc/AuthEditLDAP.js
> > @@ -79,6 +79,21 @@ Ext.define('PVE.panel.LDAPInputPanel', {
> >  	    },
> >  	];
> >
> > +	me.advancedItems = [
> > +	    {
> > +		xtype: 'proxmoxcheckbox',
> > +		fieldLabel: gettext('Check connection'),
> > +		name: 'check-connection',
> > +		uncheckedValue: 0,
> > +		checked: me.isCreate,
> > +		autoEl: {
> > +		    tag: 'div',
> > +		    'data-qtip':
> > +			gettext('Verify connection parameters and bind credentials on save'),
> > +		},
> > +	    },
> > +	];
> > +
> >  	me.callParent();
> >      },
> >      onGetValues: function(values) {
>
> AD realms have their own GUI component, so I guess it would also make sense to
> add the new parameter there.
Right, forgot that. I'll add it for v2, thanks!