[pve-devel] applied: [PATCH novnc] don't show error messages for users without VM.Audit privileges

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Oct 10 10:45:47 CEST 2022


Am 07/10/2022 um 10:44 schrieb Dominik Csapak:
> we now query the guest status before starting, but that requires VM.Audit
> privileges, which are not necessary since only VM.Console is actually
> required to connect to the console.
> 
> In that case, skip the error message and continue connecting
> 
> reported in the forum:
> https://forum.proxmox.com/threads/vm-console-require-vm-audit.116176/
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  ...ow-start-button-on-not-running-vm-ct.patch | 26 ++++++++++++++-----
>  1 file changed, 20 insertions(+), 6 deletions(-)
> 
>

applied, but reworked commit message for more context (or maybe better said,
reword it such that it's a bit clearer why/what/how) and to avoid sounding a
bit like that this is a front end solution for a issue where we allowed to
query the guest status if only VM.Console was present, thanks!





More information about the pve-devel mailing list