[pve-devel] [PATCH v2 qemu-server 1/1] Warn in GUI for unlikely iothread config

Matthias Heiserer m.heiserer at proxmox.com
Thu Apr 28 10:44:49 CEST 2022


Previously, only a plaintext line in the task log showed something was off.
Now, the GUI will show it as a warning.

Signed-off-by: Matthias Heiserer <m.heiserer at proxmox.com>
---

No changes from v1

 PVE/QemuServer.pm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 5366df2..d1f612b 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3952,7 +3952,9 @@ sub config_to_command {
 		$iothread .= ",iothread=iothread-$controller_prefix$controller";
 		push @$cmd, '-object', "iothread,id=iothread-$controller_prefix$controller";
 	    } elsif ($drive->{iothread}) {
-		warn "iothread is only valid with virtio disk or virtio-scsi-single controller, ignoring\n";
+		PVE::RESTEnvironment::log_warn(
+		    "iothread is only valid with virtio disk or virtio-scsi-single controller, ignoring\n"
+		);
 	    }
 
 	    my $queues = '';
-- 
2.30.2






More information about the pve-devel mailing list