[pmg-devel] [PATCH pmg-api/docs] make filter timeout configurable

Dominik Csapak d.csapak at proxmox.com
Fri Jan 12 09:35:09 CET 2024


gave this a look & spin, and it works as intended

writing here what we discussed off-list:

there is still the same race when processing + the actual action
takes longer than the time out, but that is no trivially fixable

for "normal" timeouts (e.g. the default of 600s) this should not
matter much, except for pathological cases where e.g. writing
to the quarantine takes an absurd amount of time

secondly, we probably should adapt the timeouts for virus+custom check scripts
to the configured one too (or e.g. half) but that can be done afterwards
and does not impact the actual issue here
(except that probably the command runs unnecessarily long)

IMHO we should still mark the increased timeout for before queue filter
in the next release notes, since that can be a bit unexpected

so from my side, this series is:

Reviewed-by: Dominik Csapak <d.csapak at proxmox.com>
Tested-by: Dominik Csapak <d.csapak at proxmox.com>




More information about the pmg-devel mailing list