[pmg-devel] applied-partially: [PATCH pmg-api/docs/gui v2] implement and combination and inversion of groups and objects

[Stoiko Ivanov]

huge thanks for the series and the quick iteration on my nits!

applied the api and docs patches, left the gui patches for now after a
talk with Thomas off-list.




On Wed, 21 Feb 2024 13:24:26 +0100
Dominik Csapak <d.csapak at proxmox.com> wrote:

> This series is the backend part of the and/inversion addition to the
> rule system.
> 
> The gui change is rather simple, just one additional drop down for
> groups + one for each type in each rule.
> 
> changes from v1:
> * rebase on master
> * include new tables in cluster sync + backup
> * incorporate stoikos feedback
> * improved commit messages
> more details in the relevant patches
> 
> changes from rfc:
> * added docs + gui
> * some minor bugfixes
> * fixed the api (forgot to add the info to the GET calls in rfc)
> * changed output for `pmgdb dump` so we get that info in the pmgreport too
> 
> pmg-api:
> 
> Dominik Csapak (10):
>   RuleCache: reorganize how we  gather marks and spaminfo
>   api: refactor rule parameters
>   add objectgroup attributes and/invert
>   add rule attributes and/invert (for each relevant type)
>   RuleCache: load rule/objectgroup attributes from database
>   RuleCache: implement and/invert for when/from/to
>   MailQueue: return maximum AID
>   ModGroup: add possibility to explode to all targets
>   RuleCache: implement and/invert for what matches
>   pmgdb: extend dump output to include add/invert
> 
>  src/PMG/API2/ObjectGroupHelpers.pm |  51 +++++-
>  src/PMG/API2/RuleDB.pm             |  23 +--
>  src/PMG/API2/Rules.pm              |  94 ++++++++--
>  src/PMG/Backup.pm                  |   2 +
>  src/PMG/CLI/pmgdb.pm               |  38 +++-
>  src/PMG/Cluster.pm                 |   4 +
>  src/PMG/DBTools.pm                 |  32 ++++
>  src/PMG/MailQueue.pm               |   4 +-
>  src/PMG/ModGroup.pm                |  17 ++
>  src/PMG/RuleCache.pm               | 274 +++++++++++++++++++++++-----
>  src/PMG/RuleDB.pm                  | 278 +++++++++++++++++++++++------
>  src/PMG/RuleDB/Remove.pm           |  28 ++-
>  src/PMG/Utils.pm                   |   2 +
>  src/bin/pmg-smtp-filter            |  23 +--
>  14 files changed, 701 insertions(+), 169 deletions(-)
> 
> pmg-docs:
> 
> Dominik Csapak (1):
>   rule system: explain new and mode and invert flag
> 
>  pmg-mail-filter.adoc | 40 +++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 39 insertions(+), 1 deletion(-)
> 
> pmg-gui:
> 
> Dominik Csapak (2):
>   rules: use tree panel instead of grouping feature of the grid
>   rules/objects: add mode selector dropdown
> 
>  css/ext6-pmg.css               |   7 +++
>  js/Makefile                    |   1 +
>  js/ObjectGroup.js              |  64 +++++++++++++++++++-
>  js/ObjectGroupConfiguration.js |   4 ++
>  js/RuleInfo.js                 | 103 ++++++++++++++++++++++++++-------
>  js/form/ModeSelector.js        |  11 ++++
>  6 files changed, 167 insertions(+), 23 deletions(-)
>  create mode 100644 js/form/ModeSelector.js
>