[pmg-devel] [PATCH log-tracker 1/2] add clamd signature found messages to log output

[Stoiko Ivanov]

hi,


On Fri, 4 Aug 2023 14:09:32 +0200
Dominik Csapak <d.csapak at proxmox.com> wrote:

> hi,
> 
> in general it works and does what is says,
> but after looking at the log tracker output, i'm nto sure if it's worth
> it. we log the same info directly after that from the pmg-smtp-filter...
> 
> otoh, the code is not that big and probably doesn't hurt either
> 
> @stoiko, maybe you have some input on that?
hm - a bit ambivalent on this:
* on the one hand - having more information, which is useful for most
  common setups (only ClamAV is used) might help
* on the other hand - if we have exactly the same information (which virus
  was detected, and by which engine one line below I don't see the benefit
  of adding more lines)

Currently I'd rather not apply it - but I'm not too set on this either.


> 
> in any case, consider both patches
> 
> Reviewed-by: Dominik Csapak <d.csapak at proxmox.com>
> Tested-by: Dominik Csapak <d.csapak at proxmox.com>
> 
> 
> 
> 
> _______________________________________________
> pmg-devel mailing list
> pmg-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
> 
>