[pmg-devel] applied: [PATCH pmg-gui v3] backup-configuration: Add icons to tab buttons

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Sep 7 08:33:40 CEST 2023


Am 06/09/2023 um 15:09 schrieb Maximiliano Sandoval:
> From a UX perspective flat buttons, i.e. buttons without a frame or
> background, are not obviously clickable without an icon.
> 
> The choice of icons was taken from pve-manager's Utils.js module.

I amended the commit to mention the storageSchema map and change
Utils.js to PVE.Utils, as that's the module name relevant when
actually using it.

> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
> ---
> Differences from v2:
>   - Use folder icon as suggest in v2 of the patch
>   - Improved commit message
> 
>  js/BackupConfiguration.js | 2 ++
>  1 file changed, 2 insertions(+)
> 
>

applied, thanks!




More information about the pmg-devel mailing list